[YUNIKORN-287] reserved ask release double release #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an ask gets released that is reserved and being allocated the counters tracking reservations can be updated twice for one ask release. The counters keep track of the number of reservations on a queue or partition. This can lead to other reservations being ignored. Nodes that have been reserved by other asks for the same app will be skipped during scheduling. In a small cluster this could lead to resource starvation
|
I have added a test case which fails without the changes and passes with the changes. |
error should be the last type when returning multiple items (golint)
|
Hey @wilfred-s, TravisBuddy Request Identifier: 1c5d9c70-c766-11ea-999c-bf5bae978323 |
yangwwei
approved these changes
Jul 16, 2020
wilfred-s
added a commit
that referenced
this pull request
Jul 17, 2020
When an ask gets released that is reserved and being allocated the counters tracking reservations can be updated twice for one ask release. The counters keep track of the number of reservations on a queue or partition. This can lead to other reservations being ignored. Nodes that have been reserved by other asks for the same app will be skipped during scheduling. In a small cluster this could lead to resource starvation Fixes: #185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ask gets released that is reserved and being allocated the
counters tracking reservations can be updated twice for one ask release.
The counters keep track of the number of reservations on a queue or
partition.
This can lead to other reservations being ignored. Nodes that have been
reserved by other asks for the same app will be skipped during
scheduling. In a small cluster this could lead to resource starvation