Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-311] Code coverage is not updating for the core builds #193

Closed
wants to merge 7 commits into from

Conversation

adamantal
Copy link

No description provided.

@TravisBuddy
Copy link

Hey @adamantal,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 5fe745e0-d26a-11ea-9c70-53a116b43db5

@adamantal
Copy link
Author

I checked the logs of the codecov report, and the hash matches to me.
Tried another approach: added codecov.yaml and set the wait_for_ci flag to false. This should theoretically force the codecov bot to comment on the PR. Let's wait.

@TravisBuddy
Copy link

Hey @adamantal,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d9e26d00-d32f-11ea-8b20-77bf1110b312

@TravisBuddy
Copy link

Hey @adamantal,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: b0eac240-d595-11ea-8ca9-c37e1b84d109

@TravisBuddy
Copy link

Hey @adamantal,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 153b98e0-d64b-11ea-8693-3322afd57804

@adamantal
Copy link
Author

Still nothing, even though the commit was specified with the extra option suggested above.

@TravisBuddy
Copy link

Hey @adamantal,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f8641a10-d6a1-11ea-8693-3322afd57804

@wilfred-s
Copy link
Contributor

Other builds are pushing codecov updates into the PR. I think we currently have this fixed.
Should we close this?

@adamantal
Copy link
Author

Yes, I think so. Closed.

@adamantal adamantal closed this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants