[YUNIKORN-481] deadlock when removing allocation ask

[wilfred-s]

When removing an allocationAsk the partition was locked before the
application scheduling itself does it the other way around which can
cause a deadlock if the ask is removed while the application is
scheduled.
Possible deadlock in the node usage calculation removed.

Removal of an allocation contains a possible deadlock which has not been
handled as YUNIKORN-461 is open for changing that behaviour already.

E2E tests run as part of the k8shim cover the testing.

[kingamarton]

The changes LGTM. Let's wait for the pre commit checks and then from my side it can be merged.

[codecov]

Codecov Report

Merging #228 (4b7bed9) into master (9f0f1ce) will increase coverage by 0.01%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   63.08%   63.09%   +0.01%     
==========================================
  Files          59       59              
  Lines        4857     4875      +18     
==========================================
+ Hits         3064     3076      +12     
- Misses       1651     1657       +6     
  Partials      142      142              

Impacted Files	Coverage Δ
pkg/scheduler/objects/node.go	83.33% <0.00%> (-1.98%)	⬇️
pkg/scheduler/partition.go	64.90% <66.66%> (+<0.01%)	⬆️
pkg/scheduler/objects/allocation.go	77.77% <100.00%> (ø)
pkg/scheduler/objects/application.go	55.30% <100.00%> (+1.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0f1ce...4b7bed9. Read the comment docs.