Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-789] Add NOTICE and DISCLAIMER files to all yunikorn repos #315

Merged
merged 1 commit into from Aug 26, 2021

Conversation

kobe860219
Copy link
Contributor

@kobe860219 kobe860219 commented Aug 26, 2021

What is this PR for?

Add NOTICE and DISCLAIMER files to repo

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-789

How should this be tested?

https://github.com/apache/incubator-yunikorn-core/pull/315/checks?check_run_id=3428521996

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #315 (892695f) into master (5a1c19e) will increase coverage by 2.84%.
The diff coverage is 67.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   63.46%   66.31%   +2.84%     
==========================================
  Files          60       62       +2     
  Lines        5220     5810     +590     
==========================================
+ Hits         3313     3853     +540     
- Misses       1747     1755       +8     
- Partials      160      202      +42     
Impacted Files Coverage Δ
pkg/common/utils.go 77.50% <0.00%> (ø)
pkg/metrics/init.go 62.96% <ø> (ø)
pkg/scheduler/nodes_usage_monitor.go 0.00% <0.00%> (ø)
pkg/scheduler/objects/allocation.go 85.18% <ø> (-14.82%) ⬇️
pkg/webservice/webservice.go 32.25% <ø> (+19.35%) ⬆️
pkg/scheduler/context.go 16.10% <23.33%> (+9.84%) ⬆️
pkg/metrics/metrics_collector.go 64.51% <45.00%> (-9.40%) ⬇️
pkg/metrics/scheduler.go 58.92% <49.33%> (-2.66%) ⬇️
pkg/scheduler/partition_manager.go 20.00% <50.00%> (ø)
pkg/scheduler/objects/template/template.go 64.10% <64.10%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c4b2d...892695f. Read the comment docs.

Copy link
Contributor

@HuangTing-Yao HuangTing-Yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuangTing-Yao HuangTing-Yao merged commit 7c422ac into apache:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants