[YUNIKORN-958] Expose node utilisation info in new REST calls #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manirajv06 Attached screenshot of added |
manirajv06
requested changes
Jan 15, 2022
| if v > 0 { | ||
| m[name] = true | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we avoid this entire for loop and check each res value of "total" directly in below for loop?
I don't think this is required. Specifying 'utilized' filed as displayed in screenshot is good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Introduce a field in the output of the new REST call --
/ws/v1/partition/{partition}/nodesthat displays % utilization.What type of PR is it?
Todos
node_tests.goto introduce new test.What is the Jira issue?
How should this be tested?
node_tests.go(still need to implement).Screenshots (if appropriate)
Questions: