[YUNIKORN-55] Add pod labels and annotations to allocation ask attributes

[adamantal]

No description provided.

[adamantal]

Updated the PR with your review items.

Right now all the labels and annotation have been dropped off from the patch. This doesn't really make sense without at least a few of them, so @yangwwei @wilfred-s could you please list a few of them that we are going to need in the scheduler-core side?

Thanks!

[adamantal]

Updated the PR with the offline comments. Please don't merge until YUNIKORN-135 and the SI part of this issue is pushed.

[adamantal]

Using the constants from SI side. Please review apache/yunikorn-scheduler-interface#20 first.

[adamantal]

Recreated the diff because of YUNIKORN-153.

@yangwwei @wilfred-s could you please review?

[yangwwei]

hi @adamantal could you please rebase this as apache/yunikorn-scheduler-interface#20 now is merged.

[adamantal]

Thanks @yangwwei for reminding me. Rebased the patch, pending on jenkins.

[codecov-commenter]

Codecov Report

Merging #107 into master will increase coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   53.13%   53.65%   +0.51%     
==========================================
  Files          32       32              
  Lines        3030     3040      +10     
==========================================
+ Hits         1610     1631      +21     
+ Misses       1357     1346      -11     
  Partials       63       63              

Impacted Files	Coverage Δ
pkg/cache/task.go	60.16% <100.00%> (ø)
pkg/common/si_helper.go	56.04% <100.00%> (+21.47%)	⬆️
pkg/dispatcher/dispatcher.go	85.32% <0.00%> (-1.84%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace5f8b...fb6be8e. Read the comment docs.

[adamantal]

When reimplemented the patch, somehow some commits got lots (like use the constants from the SI change and to remove the annotations).
Readded the changes and fixed the review items.

[adamantal]

Thanks for merging this @yangwwei