Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-246] Travis CI: Build the docker image locally for e2e tests. #150

Merged
merged 14 commits into from Jul 10, 2020
Merged

[YUNIKORN-246] Travis CI: Build the docker image locally for e2e tests. #150

merged 14 commits into from Jul 10, 2020

Conversation

yangwwei
Copy link
Contributor

@yangwwei yangwwei commented Jul 7, 2020

Ensure e2e tests are running against the latest codebase.

@yangwwei yangwwei self-assigned this Jul 7, 2020
@yangwwei yangwwei marked this pull request as draft July 7, 2020 08:21
@yangwwei yangwwei changed the title [YUNIKORN-246]. Travis CI: Build the docker image locally for e2e tests. [YUNIKORN-246] Travis CI: Build the docker image locally for e2e tests. Jul 9, 2020
@yangwwei yangwwei marked this pull request as ready for review July 10, 2020 05:46
Copy link
Contributor

@ayubpathan ayubpathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +2

@wangdatan
Copy link
Contributor

Thanks @yangwwei , patch looks good, the new structure looks much better than before. +1

@yangwwei yangwwei requested a review from wangdatan July 10, 2020 23:19
@wangdatan
Copy link
Contributor

/lgtm

Copy link
Contributor

@wangdatan wangdatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yangwwei yangwwei merged commit 1af969b into apache:master Jul 10, 2020
wilfred-s pushed a commit that referenced this pull request Jul 14, 2020
…s. (#150)

* This PR moves complex logic that handles e2e env from travis file to a separate script.
* After this PR, each travis job will build docker images from the latest code base and use those images for testing. the e2e tests will continue to run per PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants