New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-246] Travis CI: Build the docker image locally for e2e tests. #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se images for e2e tests.
yangwwei
changed the title
[YUNIKORN-246]. Travis CI: Build the docker image locally for e2e tests.
[YUNIKORN-246] Travis CI: Build the docker image locally for e2e tests.
Jul 9, 2020
ayubpathan
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +2
Thanks @yangwwei , patch looks good, the new structure looks much better than before. +1 |
/lgtm |
wangdatan
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
wilfred-s
pushed a commit
that referenced
this pull request
Jul 14, 2020
…s. (#150) * This PR moves complex logic that handles e2e env from travis file to a separate script. * After this PR, each travis job will build docker images from the latest code base and use those images for testing. the e2e tests will continue to run per PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure e2e tests are running against the latest codebase.