[YUNIKORN-282] K8shim may have staled nodes causing problems. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfred-s
approved these changes
Jul 15, 2020
wilfred-s
pushed a commit
that referenced
this pull request
Jul 15, 2020
Nodes can be removed and added back again using the same identifier. The informer can change that remove and add into an update. This can cause stale information in the shim cache. The fix makes sure the cache is correctly cleaned up in this case. YUNIKORN-220 relies on the cache to be clean. Fixes: #158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding/removing nodes back and force, and nodes are created with the same name. In such cases, the shared index informer may trigger
Updateevent instead of anAdd(resource key is the same). If the node has stale info in the cache, this will cause the fix we did for YUNIKORN-220 not work. We need to make sure when a node is deleted, the corresponding info is also deleted from the cache.