[YUNIKORN-536] Add resource requests and limits for the admission-controller #227
Conversation
This reverts commit bb50cc6.
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 59.75% 59.51% -0.24%
==========================================
Files 35 35
Lines 3133 3127 -6
==========================================
- Hits 1872 1861 -11
- Misses 1180 1184 +4
- Partials 81 82 +1
Continue to review full report at Codecov.
|
| limits: | ||
| cpu: "100m" | ||
| memory: 500Mi | ||
| requests: | ||
| cpu: "500m" | ||
| memory: 500Mi |
There was a problem hiding this comment.
Can you please explain how you decided about this values?
There was a problem hiding this comment.
I've done some observations on a live cluster, leveraging kubectl top command, I was able to see the resource utilization of the admission controller pod, it is not using a lot of resources. I tried to create hundreds of pods in a loop to add some loads, it only uses 1~2m CPU, and less than 10m memory, pretty lightweight. So I think this number is sufficient.
The admission controller must have a cpu and memory request and limit set to not be considered a best effort pod. Without the settings K8s could throttle the admission controller causing pod creation delays. Throttling down can show as kubectl failures. Update logging to only logs pods and response. Fixes: #227
The admission controller must have a cpu and memory request and limit set to not be considered a best effort pod. Without the settings K8s could throttle the admission controller causing pod creation delays. Throttling down can show as kubectl failures. Update logging to only logs pods and response. Fixes: apache#227
No description provided.