[YUNIKORN-521] Placeholder pods are not cleaned when the job is deleted #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is deleted Filled ownreference field for the placeholder pods
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 59.75% 59.43% -0.33%
==========================================
Files 35 35
Lines 3133 3229 +96
==========================================
+ Hits 1872 1919 +47
- Misses 1180 1228 +48
- Partials 81 82 +1
Continue to review full report at Codecov.
|
yangwwei
requested changes
Feb 20, 2021
wilfred-s
reviewed
Mar 2, 2021
yangwwei
reviewed
Mar 16, 2021
yangwwei
reviewed
Mar 16, 2021
yangwwei
pushed a commit
that referenced
this pull request
Mar 16, 2021
…ed (#232) Add the owner reference to the placeholder pods in order to do proper cleanup. The owner reference is the same value as the first pod of the app's owner reference, if the first pod doesn't have an owner reference set, it is set to the pod's object.
craigcondit
pushed a commit
to craigcondit/yunikorn-k8shim
that referenced
this pull request
May 10, 2022
…ed (apache#232) Add the owner reference to the placeholder pods in order to do proper cleanup. The owner reference is the same value as the first pod of the app's owner reference, if the first pod doesn't have an owner reference set, it is set to the pod's object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filled ownreference field for the placeholder pods