[YUNIKORN-641]: Add events for placeholder timeout to pod #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 65.53% 66.10% +0.57%
==========================================
Files 40 40
Lines 6406 6441 +35
==========================================
+ Hits 4198 4258 +60
+ Misses 2045 2018 -27
- Partials 163 165 +2
Continue to review full report at Codecov.
|
manirajv06
force-pushed
the
YUNIKORN-641
branch
from
1d8bb66
to
3e55c2a
Compare
wilfred-s
requested changes
Aug 12, 2021
manirajv06
force-pushed
the
YUNIKORN-641
branch
from
3e55c2a
to
b47a8f6
Compare
yangwwei
changed the title
manirajv06
force-pushed
the
YUNIKORN-641
branch
from
f7d03c0
to
5db65a0
Compare
…od"" This reverts commit abc6e7f.
|
@craigcondit Can you please take a look? |
craigcondit
requested changes
May 18, 2022
pbacsko
reviewed
May 18, 2022
pbacsko
reviewed
May 18, 2022
pbacsko
reviewed
May 18, 2022
craigcondit
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Pod originates the app request has been considered as "first pod" to send event incase of placeholders timeout. This "first pod" is derived using pod's owner references as it already contains the necessary info once the corresponding task has been added to the app.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-641
How should this be tested?
Screenshots (if appropriate)
Questions: