[YUNIKORN-561]Some container tags are missing upon scheduler restart #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 59.75% 63.00% +3.25%
==========================================
Files 35 37 +2
Lines 3133 3433 +300
==========================================
+ Hits 1872 2163 +291
- Misses 1180 1185 +5
- Partials 81 85 +4
Continue to review full report at Codecov.
|
yangwwei
requested changes
Jul 23, 2021
pkg/common/si_helper.go
Outdated
Comment on lines
46
to
49
| func CreateTagsForTask(pod *v1.Pod) map[string]string { | ||
| return createTagsForTask(pod) | ||
| } | ||
|
|
There was a problem hiding this comment.
Looks good, for simplicity, I think we can just rename this function to CreateTagsForTask to expose it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix the AllocationTags missing when scheduler restart.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-561
How should this be tested?
Screenshots (if appropriate)
Questions: