Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YUNIKORN-906: Shim side changes of YUNIKORN-337 #321

Closed
wants to merge 7 commits into from

Conversation

manirajv06
Copy link
Contributor

What is this PR for?

https://issues.apache.org/jira/browse/YUNIKORN-906

What type of PR is it?

  • - Improvement

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-906

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@manirajv06 manirajv06 force-pushed the YUNIKORN-906 branch 2 times, most recently from f4255d0 to a008f72 Compare November 5, 2021 06:55
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #321 (a26db7d) into master (c47ed51) will increase coverage by 1.83%.
The diff coverage is 64.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   59.75%   61.58%   +1.83%     
==========================================
  Files          35       39       +4     
  Lines        3133     3639     +506     
==========================================
+ Hits         1872     2241     +369     
- Misses       1180     1293     +113     
- Partials       81      105      +24     
Impacted Files Coverage Δ
pkg/appmgmt/appmgmt_recovery.go 67.50% <0.00%> (-8.18%) ⬇️
pkg/cache/amprotocol_mock.go 0.00% <0.00%> (ø)
pkg/cache/context_recovery.go 45.23% <0.00%> (-1.11%) ⬇️
pkg/common/events/recorder_mock.go 0.00% <0.00%> (ø)
pkg/common/events/states.go 0.00% <0.00%> (ø)
pkg/shim/main.go 0.00% <0.00%> (ø)
...missioncontrollers/webhook/admission_controller.go 29.12% <4.76%> (-3.62%) ⬇️
pkg/cache/context.go 37.36% <19.56%> (-3.72%) ⬇️
pkg/shim/scheduler.go 78.41% <20.00%> (-1.15%) ⬇️
pkg/common/events/recorder.go 33.33% <33.33%> (+3.33%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3faaccb...a26db7d. Read the comment docs.

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the 3 calls that are nop's in the core this looks good.
Please check those calls and if they are needed to pass tests etc we should fix the tests but we should not leave the nop calls in the production code.

pkg/cache/node.go Outdated Show resolved Hide resolved
pkg/cache/node.go Outdated Show resolved Hide resolved
pkg/cache/node.go Outdated Show resolved Hide resolved
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for a build to pass before we commit the change
depends on #327

@wilfred-s wilfred-s closed this in 85b284c Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants