New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YUNIKORN-906: Shim side changes of YUNIKORN-337 #321
Conversation
f4255d0
to
a008f72
Compare
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 59.75% 61.58% +1.83%
==========================================
Files 35 39 +4
Lines 3133 3639 +506
==========================================
+ Hits 1872 2241 +369
- Misses 1180 1293 +113
- Partials 81 105 +24
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the 3 calls that are nop's in the core this looks good.
Please check those calls and if they are needed to pass tests etc we should fix the tests but we should not leave the nop calls in the production code.
c83ad97
to
d236e4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for a build to pass before we commit the change
depends on #327
What is this PR for?
https://issues.apache.org/jira/browse/YUNIKORN-906
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-906
How should this be tested?
Screenshots (if appropriate)
Questions: