Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-49] K8shim should report occupied resources to scheduler core #86

Closed
wants to merge 11 commits into from
Closed

[YUNIKORN-49] K8shim should report occupied resources to scheduler core #86

wants to merge 11 commits into from

Conversation

yangwwei
Copy link
Contributor

No description provided.

@yangwwei yangwwei requested review from wilfred-s and removed request for wilfred-s March 24, 2020 19:31
@wilfred-s wilfred-s self-requested a review March 25, 2020 14:15
@wilfred-s wilfred-s added the enhancement New feature or request label Mar 25, 2020
@yangwwei yangwwei changed the title [YUNIKORN-16] co-exist with default scheduler [YUNIKORN-49] K8shim should report occupied resources to scheduler core Mar 26, 2020
wilfred-s
wilfred-s requested changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please look at the import ordering as discussed

pkg/cache/node_coordinator.go Outdated Show resolved Hide resolved
pkg/cache/node_coordinator.go Outdated Show resolved Hide resolved
pkg/cache/node_coordinator.go Outdated Show resolved Hide resolved
pkg/cache/task.go Outdated Show resolved Hide resolved
pkg/common/resource.go Outdated Show resolved Hide resolved
pkg/common/resource.go Outdated Show resolved Hide resolved
pkg/common/resource_test.go Outdated Show resolved Hide resolved
wilfred-s
wilfred-s approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment on the resource sub code which I will fix on commit together with some fmt fixes

wilfred-s added a commit that referenced this pull request Mar 27, 2020
@yangwwei @wilfred-s
[YUNIKORN-49] Report occupied resources (#86)
87534c9 
Resources allocated by the default or other 3rd party scheduler need to
be reported to the core. The core excludes these occupied resources from
the total node resources when scheduling.

Co-authored-by: Wilfred Spiegelenburg <wilfreds@apache.org>
@wilfred-s
Copy link
Contributor

thank you, changes committed

@wilfred-s wilfred-s closed this Mar 27, 2020
@wilfred-s wilfred-s deleted the YUNIKORN-16 branch March 27, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfred-s wilfred-s wilfred-s approved these changes

Assignees

@yangwwei yangwwei

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@yangwwei @wilfred-s