[YUNIKORN-419] Add helm package to release tool #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation on how to release is missing information around packaging and signing of the helm chart. Add building the helm chart package to the release tool. Extend the signing to include the helm package. Generate a digest (checksum) if signing is not possible for updating the index file. Add checks for the availability of gpg and helm tools on the path.
|
@kingamarton can you please take a look at this? |
kingamarton
approved these changes
Sep 17, 2020
|
@wilfred-s I checked the changes, and LGTM. I think everything is covered and documented in detail. |
|
hi @kingamarton if this looks good to you, could you pls get this merged? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation on how to release is missing information around packaging
and signing of the helm chart.
Add building the helm chart package to the release tool. Extend the
signing to include the helm package. Generate a digest (checksum) if
signing is not possible for updating the index file.
Add checks for the availability of gpg and helm tools on the path.