Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-864] update design documentation with new interface #88

Merged
merged 3 commits into from Apr 7, 2022

Conversation

manirajv06
Copy link
Contributor

update scheduler core design documentation with new interface

@wilfred-s
Copy link
Contributor

wilfred-s commented Nov 9, 2021

Based on the comment in the top of the document I think we should not update the scheduler_core_design.md at all: caution message in the doc
The messages processing has been simplified with the removal of the scheduler cache and most, if not all, of the document is obsolete. We should really start work on YUNIKORN-495 to get this fixed.

@manirajv06
Copy link
Contributor Author

Ok. Let me give a try on YUNIKORN-495

@manirajv06
Copy link
Contributor Author

@wilfred-s as discussed offline, created a new doc to describe interface message simplification, code flow analysis based on message changes, breaking shim dependency etc. Please take a look. Yes, we will need to revert previous commit done on Scheduler Cache design doc and we may need to add a caution header to Scheduler cache removal design doc to refer to this new doc.

@craigcondit craigcondit changed the title YUNIKORN-864:update design documentation with new interface [YUNIKORN-864] update design documentation with new interface Feb 1, 2022
@wilfred-s
Copy link
Contributor

I have reverted the file that we do not maintain anymore.

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilfred-s wilfred-s merged commit 7083a8a into apache:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants