Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-129] missing license headers #36

Merged
merged 1 commit into from
May 8, 2020
Merged

[YUNIKORN-129] missing license headers #36

merged 1 commit into from
May 8, 2020

Conversation

wilfred-s
Copy link
Contributor

Include new make target for a license check, consistent with the other
repos: check-license.

@wilfred-s
[YUNIKORN-129] missing license headers
5dbfcad 
Include new make target for a license check, consistent with the other
repos: check-license.
@wilfred-s wilfred-s self-assigned this May 8, 2020
@yangwwei
Copy link
Contributor

yangwwei commented May 8, 2020

LGTM. Merging now.
One question, is this PR fixed all files that missed license headers?

@yangwwei yangwwei merged commit 3b47608 into apache:master May 8, 2020
@wilfred-s wilfred-s deleted the yunikorn-129 branch May 8, 2020 05:15
@wilfred-s
Copy link
Contributor Author

LGTM. Merging now.
One question, is this PR fixed all files that missed license headers?

it should be as the list for changes was generated using the new check-license make target.
json files can not have comments, adding a license is thus not possible. There might be a file without extension that did not get caught but they should all be configs rather than code or documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangwwei yangwwei yangwwei approved these changes

Assignees

@wilfred-s wilfred-s

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wilfred-s @yangwwei