Fixing Zeppelin-838: Minor improvement to error message #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The term "note" is in fact used in a few places to refer to a notebook. I don't have a preference either way so I'd leave others to comment on that. |
|
Thanks for the review @felixcheung. Would be great to get another review and if there are no comments, can someone help get it merged upstream. |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
Merging this if no more discussion. |
shijinkui
pushed a commit
to shijinkui/incubator-zeppelin
that referenced
this pull request
May 26, 2016
### What is this PR for? This JIRA improves the error message displayed when the current user opens a notebook to which the user is not allowed access to. ### What type of PR is it? [Minor Improvement ] ### Todos * None ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-838 ### How should this be tested? Get the change in this pull request. Build Zeppelin, configure shiro authentication by commenting out the 1st line below and modifying the corresponding line for 2nd line. #/** = anon /** = authcBasic Log in as user1, configure a notebook to only allow access to only user1, now access that same notebook as user2 and note the new error message. ### Screenshots (if appropriate) [Screenshot:-Before](https://issues.apache.org/jira/secure/attachment/12802057/Screen%20Shot%202016-05-03%20at%203.16.58%20PM.png) [Screenshot:-After](https://issues.apache.org/jira/secure/attachment/12802065/Screen%20Shot%202016-05-03%20at%203.17.36%20PM.png) ### Questions: * Does the licenses files need update? --No * Is there breaking changes for older versions? --No * Does this needs documentation? -- No Author: Vinay Shukla <vshukla@HW12335.local> Closes apache#872 from vinayshukla/zeppelin-838 and squashes the following commits: ce4b3bd [Vinay Shukla] Fixing Zeppelin-838: Minor improvement to error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This JIRA improves the error message displayed when the current user opens a notebook to which the user is not allowed access to.
What type of PR is it?
[Minor Improvement ]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-838
How should this be tested?
Get the change in this pull request. Build Zeppelin, configure shiro authentication by commenting out the 1st line below and modifying the corresponding line for 2nd line.
/** = anon
/** = authcBasic
Log in as user1, configure a notebook to only allow access to only user1, now access that same notebook as user2 and note the new error message.
Screenshots (if appropriate)
Screenshot:-Before
Screenshot:-After
Questions: