Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move zeppelin version from home page to about section #951

Closed
wants to merge 3 commits into from

Conversation

prabhjyotsingh
Copy link
Contributor

What is this PR for?

Move zeppelin version that is shown home page to new about section.

What type of PR is it?

[Improvement]

Todos

N/A

What is the Jira issue?

ZEPPELIN-943

How should this be tested?

Please refer the gif below.

Screenshots (if appropriate)

Before:
screen shot 2016-06-02 at 3 43 54 pm

After:

Without authentication
gif1

With authentication
gif2

Questions:

  • Does the licenses files need update? N/A
  • Is there breaking changes for older versions? N/A
  • Does this needs documentation? N/A

@vinayshukla
Copy link
Contributor

This is a useful way to find the Zeppelin version number. +1

<li><a href="" data-toggle="modal" data-target="#aboutModal" >
<i style="font-size: 15px;" class="fa fa-info"></i> About</a></li>
<li ng-show="ticket.principal && ticket.principal!='anonymous'" style="left: 5px;">
<a ng-click="logout()" tooltip-placement="bottom" tooltip="logout">Logout</a>
Copy link
Contributor

@AhyoungRyu AhyoungRyu Jun 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prabhjyotsingh In my personal opinion, we don't need another tooltip on Logout button(I know this tooltip has been existed ago). Users can aware that this is logout button without tooltip i think :)
screen shot 2016-06-02 at 9 42 33 am

What do you think ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, removed it.

@AhyoungRyu
Copy link
Contributor

@prabhjyotsingh Big +1 for this improvement! 👍
This is really minor thing and just my personal opinion, but can we add more space between the connect status circle and the drop-down button ? I think they are too close. What do you think ?

  • Without authentication
    screen shot 2016-06-02 at 9 56 26 am
  • With authentication
    screen shot 2016-06-02 at 9 56 10 am

@Leemoonsoo
Copy link
Member

Tested and it looks cool.

It's also my personal preference, to me, moving status circle into dropdown button seems better. And highlight drop down button background color only when cursor hover looks more clean to me.

@AhyoungRyu
Copy link
Contributor

Regarding highlight drop down button, I agree with @Leemoonsoo.

@prabhjyotsingh
Copy link
Contributor Author

Thank you @AhyoungRyu and @Leemoonsoo for the feedback, have implemented.

@Leemoonsoo
Copy link
Member

Cool. Font size of "Connected" text seems changed. Is it intended?

Before
image

After
image

@prabhjyotsingh
Copy link
Contributor Author

prabhjyotsingh commented Jun 4, 2016

Yes @Leemoonsoo, it was intended. Since, now [Connected/Disconnected] is no more just text its same as one of the action link like Notebook, Interpreter etc. i think it should share same styling as them.

@Leemoonsoo
Copy link
Member

Thanks for the explanation. LGTM

@prabhjyotsingh
Copy link
Contributor Author

Merging this if no more discussion.

@asfgit asfgit closed this in 36b3b8d Jun 7, 2016
@prabhjyotsingh prabhjyotsingh deleted the ZEPPELIN-943 branch August 15, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants