New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move zeppelin version from home page to about section #951
Conversation
eb566c6
to
172a861
Compare
172a861
to
5ed77c9
Compare
This is a useful way to find the Zeppelin version number. +1 |
<li><a href="" data-toggle="modal" data-target="#aboutModal" > | ||
<i style="font-size: 15px;" class="fa fa-info"></i> About</a></li> | ||
<li ng-show="ticket.principal && ticket.principal!='anonymous'" style="left: 5px;"> | ||
<a ng-click="logout()" tooltip-placement="bottom" tooltip="logout">Logout</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prabhjyotsingh In my personal opinion, we don't need another tooltip on Logout button(I know this tooltip has been existed ago). Users can aware that this is logout button without tooltip i think :)
What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, removed it.
@prabhjyotsingh Big +1 for this improvement! 👍 |
Tested and it looks cool. It's also my personal preference, to me, moving status circle into dropdown button seems better. And highlight drop down button background color only when cursor hover looks more clean to me. |
Regarding highlight drop down button, I agree with @Leemoonsoo. |
Thank you @AhyoungRyu and @Leemoonsoo for the feedback, have implemented. |
6577485
to
00d811c
Compare
00d811c
to
e714e66
Compare
bc7261d
to
70aaff4
Compare
Yes @Leemoonsoo, it was intended. Since, now [Connected/Disconnected] is no more just text its same as one of the action link like Notebook, Interpreter etc. i think it should share same styling as them. |
Thanks for the explanation. LGTM |
Merging this if no more discussion. |
What is this PR for?
Move zeppelin version that is shown home page to new about section.
What type of PR is it?
[Improvement]
Todos
N/A
What is the Jira issue?
ZEPPELIN-943
How should this be tested?
Please refer the gif below.
Screenshots (if appropriate)
Before:
After:
Without authentication
With authentication
Questions: