Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-956] Download old spark versions direct from archive #967

Closed
wants to merge 1 commit into from

Conversation

lresende
Copy link
Member

@lresende lresende commented Jun 6, 2016

What is this PR for?

Older Apache Spark releases seems to have been removed from mirrors, and thus the build scripts needs to be updated to download older releases from the archives.

What type of PR is it?

[Bug Fix]

What is the Jira issue?

ZEPPELIN-956

How should this be tested?

Existing build tests

@bzz
Copy link
Member

bzz commented Jun 6, 2016

@lresende thank you for improvement!

Probavly a nitpick, but could you please check that new shell code follows project styleguide for shell?

Recently mirrors have cleaned up old Apache Spark releases and
currently only Spark 1.5.2 and newer are available in the mirrors
@lresende
Copy link
Member Author

lresende commented Jun 6, 2016

@bzz pushed some updates to fix style issues.

@bzz
Copy link
Member

bzz commented Jun 6, 2016

Thanks again!
Looks great to me.

@Leemoonsoo
Copy link
Member

LGTM and merge into master branch

@asfgit asfgit closed this in 215dd6f Jun 6, 2016
@lresende lresende deleted the download branch August 28, 2016 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants