Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][DataProxy] Unify the Usage of Message Queue #4962

Closed
1 of 2 tasks
Tracked by #4990
dockerzhang opened this issue Jul 11, 2022 · 7 comments · Fixed by #5323
Closed
1 of 2 tasks
Tracked by #4990

[Improve][DataProxy] Unify the Usage of Message Queue #4962

dockerzhang opened this issue Jul 11, 2022 · 7 comments · Fixed by #5323

Comments

@dockerzhang
Copy link
Contributor

Description

Unify the Usage of Message Queue

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@liangyepianzhou
Copy link
Contributor

Good idea! I would like to do this.

@liangyepianzhou
Copy link
Contributor

liangyepianzhou commented Jul 27, 2022

Motivation

Unify the usages of Zone Message Queue.
Now the sink and process for the MQ in the data proxy is chaotic. There is a lot of redundant code here, which makes the code's expansion and maintenance ability very poor.

Modification

We want to extract the standard part of the code.
Remove the other implementation such as xxSink and federationSink, and replace them with the zoneSink.

MQ zone

  • AbstractZoneClusterProducer
  • AbstractZoneSinkContext
  • AbstractZoneProducer
  • AbstractZoneWorker
  • AbstractZoneSink

Implement plan

  • implement AbstractClusterZoneProducer and AbstractSinkZoneContext.
  • Implement the AbstractZoneProducer.
  • implement the AbstractZoneSink and AbstractZoneWork.
  • Remove the other implementation such as xxSink and federationSink, and replace them with the zoneSink.
  • Add a document about how to extend xxZoneMQ.

@dockerzhang
Copy link
Contributor Author

@liangyepianzhou lia we do not need federation now, you can only keep zone for multi-MQ clusters.

@liangyepianzhou
Copy link
Contributor

OK, thank you for your feedback. I have modify my proposal to delete other parts except MQ zone.

@liangyepianzhou
Copy link
Contributor

The issue is adding the missing zone sink test.

@liangyepianzhou
Copy link
Contributor

The Doc issue can be found at here.

@liangyepianzhou
Copy link
Contributor

@dockerzhang @healchow
The code and documentation for this issue have been completed. In order to better show the final effect and avoid the speed of review affecting the development of the code, the previous small PRs are divided into different commits in a PR.
Please help review it when you have time, THX.

@dockerzhang dockerzhang added this to the 1.4.0 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants