Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Sort] Metrics of HBaseSinkFunction are not collected accurately #5169

Closed
2 tasks done
ifndef-SleePy opened this issue Jul 21, 2022 · 0 comments · Fixed by #5170
Closed
2 tasks done

[Bug][Sort] Metrics of HBaseSinkFunction are not collected accurately #5169

ifndef-SleePy opened this issue Jul 21, 2022 · 0 comments · Fixed by #5170
Assignees
@ifndef-SleePy
Labels
component/sort type/bug Something is wrong
Milestone
1.3.0

Comments

@ifndef-SleePy
Copy link
Contributor

What happened

  • There is a race condition of collecting metrics of HBaseSinkFunction

What you expected to happen

  • The metrics are collected in multiple threads without lock, however the metric collection (such as SimpleCounter) is not thread-safe

How to reproduce

  • It can be reproduced easily with a high TPS

Environment

No response

InLong version

master

InLong Component

InLong Sort

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ifndef-SleePy ifndef-SleePy

Labels
component/sort type/bug Something is wrong
Projects
None yet
Milestone
1.3.0
2 participants
@ifndef-SleePy @healchow