Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Manager] Optimize the creation code of databases and tables of PostgreSQL #5411

Closed
2 tasks done
haibo-duan opened this issue Aug 8, 2022 · 0 comments · Fixed by #5412
Closed
2 tasks done

[Improve][Manager] Optimize the creation code of databases and tables of PostgreSQL #5411

haibo-duan opened this issue Aug 8, 2022 · 0 comments · Fixed by #5412
Assignees
@haibo-duan
Labels
component/manager type/improve
Milestone
1.3.0

Comments

@haibo-duan
Copy link
Contributor

Description

The database and tables creation code of PostgreSQL has the following problems:

  • The database connection cannot be reused. It is not a good way to create a new connection every time.
  • Instead of creating a database, create a schema.
  • There are some bugs in these codes, as follows:
    image

image

InLong Component

InLong Manager

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
@haibo-duan haibo-duan mentioned this issue Aug 8, 2022
Merged
3 tasks
@dockerzhang dockerzhang added this to the 1.3.0 milestone Aug 9, 2022
@healchow healchow changed the title [Improve][Manager] Optimize the creation code of databases and tables of PostgerSQL [Improve][Manager] Optimize the creation code of databases and tables of PostgreSQL Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haibo-duan haibo-duan

Labels
component/manager type/improve
Projects
None yet
Milestone
1.3.0
3 participants
@haibo-duan @dockerzhang @healchow