Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][TubeMQ] Missing log content in the tests directory #5687

Closed
2 tasks done
gosonzhang opened this issue Aug 25, 2022 · 0 comments · Fixed by #5688
Closed
2 tasks done

[Improve][TubeMQ] Missing log content in the tests directory #5687

gosonzhang opened this issue Aug 25, 2022 · 0 comments · Fixed by #5688
Assignees
@gosonzhang
Labels
component/tubemq type/improve
Milestone
1.4.0

Comments

@gosonzhang
Copy link
Contributor

gosonzhang commented Aug 25, 2022 •
edited

Description

The subdirectory log[1] is required, but it is not in the tests directory[2], since the "log" name is ignored in the .gitignore file, change the directory name to "logger_test".

  1. https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-client-twins/tubemq-client-cpp/tests/CMakeLists.txt#L32
    image

  2. https://github.com/apache/inlong/tree/master/inlong-tubemq/tubemq-client-twins/tubemq-client-cpp/tests:
    image

InLong Component

InLong TubeMQ

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gosonzhang gosonzhang

Labels
component/tubemq type/improve
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

[INLONG-5687][TubeMQ] Missing log content in the tests directory
2 participants
@gosonzhang @dockerzhang