Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][TubeMQ] Remove the virtual keyword of the destructor of the TubeMQTDMsg and DataItem classes #5748

Closed
2 tasks done
gosonzhang opened this issue Aug 31, 2022 · 0 comments · Fixed by #5750
Closed
2 tasks done

[Improve][TubeMQ] Remove the virtual keyword of the destructor of the TubeMQTDMsg and DataItem classes #5748

gosonzhang opened this issue Aug 31, 2022 · 0 comments · Fixed by #5750
Assignees
@gosonzhang
Labels
component/tubemq type/improve
Milestone
1.4.0

Comments

@gosonzhang
Copy link
Contributor

Description

The destructors of the TubeMQTDMsg and DataItem classes carry the virtual keyword, which is easy for users to mistakenly think that they have subclasses. In fact, they are just a wrapper class for message content, and it is not recommended for users to use them as parent classes and then derive subclasses. In order to avoid misuse, the virtual keyword of the destructors of these two classes is removed here:
image

InLong Component

InLong TubeMQ

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gosonzhang gosonzhang

Labels
component/tubemq type/improve
Projects
None yet
Milestone
1.4.0
2 participants
@gosonzhang @healchow