Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][TubeMQ] Get duplicated call when calling TubeMQConsumer::Start() #5848

Closed
1 of 2 tasks
chen9t opened this issue Sep 11, 2022 · 2 comments · Fixed by #5855
Closed
1 of 2 tasks

[Bug][TubeMQ] Get duplicated call when calling TubeMQConsumer::Start() #5848

chen9t opened this issue Sep 11, 2022 · 2 comments · Fixed by #5855
Assignees
Labels
Milestone

Comments

@chen9t
Copy link

chen9t commented Sep 11, 2022

What happened

First time we call TubeMQConsumer::Start(), got "timeout".
When we want to call TubeMQConsumer::Start() again, got "duplicated call".

What you expected to happen

No duplicated call if first call is failed.

How to reproduce

  1. Call TubeMQConsumer::Start(), got "timeout";
  2. Retry TubeMQConsumer::Start() again, got "duplicated call".

Environment

No response

InLong version

master

InLong Component

InLong TubeMQ

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@chen9t chen9t added the type/bug Something is wrong label Sep 11, 2022
@gosonzhang
Copy link
Contributor

@chen9t, thanks!

@gosonzhang
Copy link
Contributor

It should be a bug in the code. When Start() exits abnormally, the status flag is not set, so the above problem occurs. The main points are as follows:

  1. tubemq_client.cc:
    https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-client-twins/tubemq-client-cpp/src/tubemq_client.cc#L69
    image

  2. baseconsumer.cc:
    https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-client-twins/tubemq-client-cpp/src/baseconsumer.cc#L62
    image

I'll fix them, thanks @chen9t

@gosonzhang gosonzhang self-assigned this Sep 11, 2022
@gosonzhang gosonzhang changed the title [Bug] Get duplicated call when calling TubeMQConsumer::Start() [Bug][TubeMQ] Get duplicated call when calling TubeMQConsumer::Start() Sep 11, 2022
@healchow healchow added this to the 1.4.0 milestone Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants