Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][DataProxy] Delete the Pulsar client synchronously when deleting a topic #6065

Closed
2 tasks done
gosonzhang opened this issue Sep 29, 2022 · 0 comments · Fixed by #6066
Closed
2 tasks done

[Bug][DataProxy] Delete the Pulsar client synchronously when deleting a topic #6065

gosonzhang opened this issue Sep 29, 2022 · 0 comments · Fixed by #6066
Assignees
Labels
Milestone

Comments

@gosonzhang
Copy link
Contributor

What happened

When PulsarSink updates the topic configure[1], it only creates a client for the newly added Topic. Still, it does not delete the corresponding client for the deleted Topic, which is prone to the problem of not releasing client resources.

  1. https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/PulsarSink.java#L249

What you expected to happen

delete the corresponding client for the deleted Topic

How to reproduce

update the topic configure and delete topics

Environment

Linux

InLong version

master

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants