Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][TubeMQ] Correct some misuse of META_DEFAULT_BROKER_PORT #6419

Closed
2 tasks done
gosonzhang opened this issue Nov 7, 2022 · 0 comments · Fixed by #6420
Closed
2 tasks done

[Bug][TubeMQ] Correct some misuse of META_DEFAULT_BROKER_PORT #6419

gosonzhang opened this issue Nov 7, 2022 · 0 comments · Fixed by #6420
Assignees
Labels
Milestone

Comments

@gosonzhang
Copy link
Contributor

What happened

When viewing the code, META_DEFAULT_BROKER_PORT is used where TLS is used, and needs to be changed, for examples:

  1. https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/master/bdbstore/bdbentitys/BdbBrokerConfEntity.java#L222
    image

  2. https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/master/metamanage/metastore/dao/entity/BrokerConfEntity.java#L190
    image

What you expected to happen

use META_DEFAULT_BROKER_TLS_PORT, not META_DEFAULT_BROKER_PORT

How to reproduce

review codes

Environment

linux

InLong version

master

InLong Component

InLong TubeMQ

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants