Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Manager] Add checks for unmodifiable field values #7229

Closed
2 tasks done
Tracked by #7168
gosonzhang opened this issue Jan 13, 2023 · 0 comments · Fixed by #7230
Closed
2 tasks done
Tracked by #7168

[Improve][Manager] Add checks for unmodifiable field values #7229

gosonzhang opened this issue Jan 13, 2023 · 0 comments · Fixed by #7230

Comments

@gosonzhang
Copy link
Contributor

Description

The parent issue is :#7168

Based on the changes in #7220, I found that during the update operation, there is no effective verification for the value check of unmodifiable fields. For example, sinkType in OpenStreamSinkController is an unmodifiable field, the original implementation Direct use without checking will cause implementation bugs; another example is the version field, which should be checked when it receives a request to reduce modification conflicts

This PR supplements the modified api in the parent issue, and the unmodified api will be improved in the subsequent sub-issue.

InLong Component

InLong Manager

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants