Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Manager] Replace getRoles() with getAccountType() #7300

Closed
2 tasks done
Tracked by #7168
gosonzhang opened this issue Feb 1, 2023 · 1 comment · Fixed by #7301
Closed
2 tasks done
Tracked by #7168

[Improve][Manager] Replace getRoles() with getAccountType() #7300

gosonzhang opened this issue Feb 1, 2023 · 1 comment · Fixed by #7301

Comments

@gosonzhang
Copy link
Contributor

Description

The parent issue: #7168

In the user authorization check of the Open APIs, the getRoles() function of the UserInfo class is used, but the getAccountType() function is used in the current Manager implementation. In order to maintain the consistency of the authentication and authorization logic, the getRoles() calls are replaced with getAccountType()

InLong Component

InLong Manager

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@healchow
Copy link
Member

healchow commented Feb 1, 2023

How do we manage users of InLong? I think we need to do some research and design, and modify the code after discussion and decision.

@healchow healchow added this to the 1.6.0 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants