You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found some ungraceful import of util tool classes in subproject of InLong Manager, e.g. manager-service
For example:
org.apache.inlong.manager.service.resource.sink.greenplum.GreenplumSqlBuilder import the org.apache.commons.compress.utils.Lists util tool class from commons-compress
org.apache.inlong.manager.service.resource.sink.postgresql.PostgreSQLSqlBuilder import the org.apache.commons.compress.utils.Lists util tool class from commons-compress
org.apache.inlong.manager.service.source.StreamSourceServiceTest import the org.apache.curator.shaded.com.google.common.collect.Maps util tool class from curator-client
I the these import util tool classes are not graceful
since the pom of manager-service does not explicitly depend on commons-compress/curator-client, manager-service uses these jars throuth the thrid party dependencies.
old version of commons-compress.jar does not contain the Lists util tool class.
Most Important, manager-service depends on manager-common, and manager-common depends on guava.
Most of the InLong proejct util tools come from guava.
I think it's more graceful to import Lists/Maps util tool classes from guava.
After full search of the project, I only found the above three classes have this problem.
coderappee
changed the title
[Improve][Manager]Ungraceful Import of Util Tool Classes
[Improve][Manager] Ungraceful Import of Util Tool Classes
Feb 12, 2023
Description
Found some ungraceful import of util tool classes in subproject of InLong Manager, e.g. manager-service
For example:
I the these import util tool classes are not graceful
Most Important, manager-service depends on manager-common, and manager-common depends on guava.
Most of the InLong proejct util tools come from guava.
I think it's more graceful to import Lists/Maps util tool classes from guava.
After full search of the project, I only found the above three classes have this problem.
InLong Component
InLong Manager
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: