Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Manager] Ungraceful Import of Util Tool Classes #7358

Closed
2 tasks done
coderappee opened this issue Feb 12, 2023 · 0 comments · Fixed by #7359
Closed
2 tasks done

[Improve][Manager] Ungraceful Import of Util Tool Classes #7358

coderappee opened this issue Feb 12, 2023 · 0 comments · Fixed by #7359

Comments

@coderappee
Copy link
Contributor

Description

Found some ungraceful import of util tool classes in subproject of InLong Manager, e.g. manager-service
For example:

  1. org.apache.inlong.manager.service.resource.sink.greenplum.GreenplumSqlBuilder import the org.apache.commons.compress.utils.Lists util tool class from commons-compress
  2. org.apache.inlong.manager.service.resource.sink.postgresql.PostgreSQLSqlBuilder import the org.apache.commons.compress.utils.Lists util tool class from commons-compress
  3. org.apache.inlong.manager.service.source.StreamSourceServiceTest import the org.apache.curator.shaded.com.google.common.collect.Maps util tool class from curator-client

I the these import util tool classes are not graceful

  1. since the pom of manager-service does not explicitly depend on commons-compress/curator-client, manager-service uses these jars throuth the thrid party dependencies.
  2. old version of commons-compress.jar does not contain the Lists util tool class.

Most Important, manager-service depends on manager-common, and manager-common depends on guava.
Most of the InLong proejct util tools come from guava.
I think it's more graceful to import Lists/Maps util tool classes from guava.

After full search of the project, I only found the above three classes have this problem.

InLong Component

InLong Manager

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@coderappee coderappee changed the title [Improve][Manager]Ungraceful Import of Util Tool Classes [Improve][Manager] Ungraceful Import of Util Tool Classes Feb 12, 2023
@dockerzhang dockerzhang added this to the 1.6.0 milestone Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants