Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][DataProxy] Optimize common.properties related control mechanism #7931

Closed
2 tasks done
gosonzhang opened this issue Apr 27, 2023 · 0 comments · Fixed by #7942
Closed
2 tasks done

[Improve][DataProxy] Optimize common.properties related control mechanism #7931

gosonzhang opened this issue Apr 27, 2023 · 0 comments · Fixed by #7942

Comments

@gosonzhang
Copy link
Contributor

Description

In the current configuration management of DataProxy, there are two parts related to common.properties control implementation, CommonPropertiesHolder and ConfigManager.getCommonProperties(). According to the analysis, this part needs to simplify the two sets of implementations into one set, and at the same time, the relevant implementation logic is adjusted as follows :

  1. It is necessary to add a mandatory requirement for common.properties configuration: the configuration file must exist when the node starts, if the file does not exist, the file fails to be read, the file content parsing fails, or the required fields in the file are not configured, the DataProxy node must output the error log, and exits;
  2. common.properties is only loaded at startup, and does not need to be loaded during operation;
  3. The acquisition of the Manager IP address in common.properties must support multiple strategies, such as configuring the domain name port, configuring the IP and port, or obtaining the corresponding Manager connection address provided by other third-party components;
  4. Unify the field configuration tags in common.properties, and align the field configuration tags that are repeated, have the same meaning but misaligned names, and are scattered everywhere

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants