Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-8547][Manager] Add workflow approver automatically when create a new tenant #8550

Merged
merged 3 commits into from Jul 18, 2023

Conversation

vernedeng
Copy link
Contributor

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng self-assigned this Jul 17, 2023
@vernedeng vernedeng requested a review from fuweng11 July 17, 2023 11:16
@vernedeng vernedeng added this to the 1.9.0 milestone Jul 17, 2023
@dockerzhang dockerzhang merged commit 7c2d266 into apache:master Jul 18, 2023
8 checks passed
vernedeng added a commit that referenced this pull request Jul 19, 2023
@healchow healchow removed this from the 1.9.0 milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Manager] Add workflow approver automatically when create a new tenant
4 participants