Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][SDK] comment/delete some debug log in some frequently called methods for Golang SDK #9172

Closed
2 tasks done
gunli opened this issue Oct 31, 2023 · 0 comments · Fixed by #9173
Closed
2 tasks done

[Improve][SDK] comment/delete some debug log in some frequently called methods for Golang SDK #9172

gunli opened this issue Oct 31, 2023 · 0 comments · Fixed by #9173
Assignees
@gunli
Labels
type/improve
Milestone
1.10.0

Comments

@gunli
Copy link
Contributor

gunli commented Oct 31, 2023

Description

Although the log level is not enabled, Some debug logs in the frequently called methods of Golang SDK will lead to string allocation, which will decrease the perf of the SDK, we need to delete/comment them.

InLong Component

InLong SDK

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gunli gunli

Labels
type/improve
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

[INLONG-9172][SDK] Delete useless debug logs in Golang SDK gunli/inlong
2 participants
@gunli @dockerzhang