Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Manager] Optimize flink job building and manage procedure #9768

Closed
2 tasks done
aloyszhang opened this issue Mar 5, 2024 · 0 comments · Fixed by #9769
Closed
2 tasks done

[Improve][Manager] Optimize flink job building and manage procedure #9768

aloyszhang opened this issue Mar 5, 2024 · 0 comments · Fixed by #9769
Assignees
Milestone

Comments

@aloyszhang
Copy link
Contributor

aloyszhang commented Mar 5, 2024

Description

Currently, long-manager builds too many objects like FlinkConfiguration, FlinkService, and FlinkOperation when building and managing Flink jobs.
The reason is, that for every single access of these classes, the manager creates a new object.
See:
https://github.com/apache/inlong/blob/master/inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkService.java#?L73~L75

   public FlinkService(String endpoint) throws Exception {
        FlinkConfiguration flinkConfiguration = new FlinkConfiguration();
        flinkConfig = flinkConfiguration.getFlinkConfig();

https://github.com/apache/inlong/blob/master/inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/listener/StartupSortListener.java#L143~L144

            FlinkService flinkService = new FlinkService(flinkInfo.getEndpoint());
            FlinkOperation flinkOperation = new FlinkOperation(flinkService);

InLong Component

InLong Manager

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants