Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Manager] reduce the creation of RestClusterClient #9825

Closed
2 tasks done
aloyszhang opened this issue Mar 15, 2024 · 0 comments · Fixed by #9826
Closed
2 tasks done

[Improve][Manager] reduce the creation of RestClusterClient #9825

aloyszhang opened this issue Mar 15, 2024 · 0 comments · Fixed by #9826
Assignees
@aloyszhang
Labels
type/improve
Milestone
1.12.0

Comments

@aloyszhang
Copy link
Contributor

aloyszhang commented Mar 15, 2024 •
edited

Description

Currently, we create a new RestClusterClient when getJobStatus, getJobDetail, stopJob, and cancelJob.

This is redundant, we can use the same ResultClustterClient for a configuration.

See current implementations.
https://github.com/apache/inlong/blob/master/inlong-manager/manager-plugins/manager-plugins-flink-v1.13/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkClientService.java

https://github.com/apache/inlong/blob/master/inlong-manager/manager-plugins/manager-plugins-flink-v1.15/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkClientService.java

InLong Component

InLong Manager

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aloyszhang aloyszhang

Labels
type/improve
Projects
None yet
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

[INLONG-9825][Manager] Reduce the creation of RestClusterClient aloyszhang/inlong
1 participant
@aloyszhang