ISIS-3200: broken Value Choices #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andi-huber
commented
Sep 2, 2022
•
andi-huber
commented
- failing regression tests (JDO related)
- failing value showcases (demo app)
themselves - also introduce URL_SAFE semantics in the context of value serializers
- no need to stringify
- handles the prePersist properly for JDO
andi-huber
commented
Sep 3, 2022
| @@ -66,23 +63,23 @@ | |||
| public class IsisEntityListener { | |||
|
|
|||
| // not managed by Spring (directly) | |||
| @Inject private ServiceInjector serviceInjector; | |||
| //@Inject private ServiceInjector serviceInjector; | |||
There was a problem hiding this comment.
optimization: we could store a INJECTONPOINTS_RESOLVED flag into the associated statemanager
|
pre-store event fixes wicket viewer 'execution' still broken as was before the branch-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.