Isis 2789 : implement EntityChangeTracker (auditing) for JPa #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhaywood
force-pushed
the
ISIS-2789
branch
2 times, most recently
from
b4668e7
to
89666ab
Compare
However, I find that the EntityChangeTrackerDefault that is queried for snapshots at end of interaction is a different instance to the one in which changes are enlisted (for an initial persist). Unsurprisingly, we get no entity property changes published. Is there an issue with @InteractionScope (InteractionScopeLifecycleHandler)
…provide the 'pre values' already. This is more efficient, but is also necessary as the pojo itself that we have will already have been updated.
…er propertyIdIfAny is provided ... because our algorithm at the moment is incorrect; it will only capture one pre value and leave the rest as null. Instead, we need to lazily populate. That's coming next.
…according to the preValues provided to us.
…eleted we use "detached" as close enough.
…x seemed to do the job
It seems that InteractionScope holds onto an old InteractionService, so that @DirtiesContext doesn't seem to properly reset.
…ndi's fix seemed to do the job" This reverts commit b940e51.
…racker for itself ... though I think the issue was a lack of @DirtiesContext in previous resulting in an InteractionScope picked up from a previous application context, somehow.
so that they explicitly have an IsisInteraction on their thread, and use @DirtiesContext in most cases.
danhaywood
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.