Skip to content

Commit

Permalink
MAILBOX-291 Review constants in Quota Bean spring stuff
Browse files Browse the repository at this point in the history
  • Loading branch information
chibenwa committed Mar 31, 2017
1 parent 8e4e162 commit 54c6402
Showing 1 changed file with 35 additions and 33 deletions.
Expand Up @@ -30,31 +30,33 @@


public class QuotaBeanFactoryPostProcessor implements BeanFactoryPostProcessor { public class QuotaBeanFactoryPostProcessor implements BeanFactoryPostProcessor {


private static final String IN_MEMORY = "inmemory"; private static final String IN_MEMORY_IMPLEMENTATION = "inmemory";
private static final String CASSANDRA = "cassandra"; private static final String CASSANDRA_IMPLEMENTATION = "cassandra";
private static final String FAKE = "fake"; private static final String FAKE_IMPLEMENTATION = "fake";
private static final String MAX_QUOTA_MANAGER = "maxQuotaManager"; private static final String MAX_QUOTA_MANAGER = "maxQuotaManager";
private static final String CURRENT_QUOTA_MANAGER = "currentQuotaManager"; private static final String JPA_IMPLEMENTATION = "jpa";
private static final String QUOTA_MANAGER = "quotaManager"; private static final String DEFAULT_IMPLEMENTATION = "default";
private static final String QUOTA_UPDATER = "quotaUpdater";
private static final String QUOTA_MANAGER_BEAN = "quotaManager";
private static final String QUOTA_UPDATER_BEAN = "quotaUpdater";
private static final String QUOTA_ROOT_RESOLVER_BEAN = "quotaRootResolver";
private static final String CURRENT_QUOTA_MANAGER_BEAN = "currentQuotaManager";
private static final String UPDATES_BEAN = "updates";

private static final String PROVIDER = "provider"; private static final String PROVIDER = "provider";
private static final String DEFAULT = "default";
private static final String UPDATES = "updates";
private static final String QUOTA_ROOT_RESOLVER = "quotaRootResolver";
private static final String EVENT = "event"; private static final String EVENT = "event";
public static final String JPA = "jpa";


@Override @Override
public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) throws BeansException { public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) throws BeansException {
ConfigurationProvider confProvider = beanFactory.getBean(ConfigurationProvider.class); ConfigurationProvider confProvider = beanFactory.getBean(ConfigurationProvider.class);
try { try {
HierarchicalConfiguration config = confProvider.getConfiguration("quota"); HierarchicalConfiguration config = confProvider.getConfiguration("quota");


String quotaRootResolver = config.configurationAt(QUOTA_ROOT_RESOLVER).getString(PROVIDER, DEFAULT); String quotaRootResolver = config.configurationAt(QUOTA_ROOT_RESOLVER_BEAN).getString(PROVIDER, DEFAULT_IMPLEMENTATION);
String currentQuotaManager = config.configurationAt(CURRENT_QUOTA_MANAGER).getString(PROVIDER, "none"); String currentQuotaManager = config.configurationAt(CURRENT_QUOTA_MANAGER_BEAN).getString(PROVIDER, "none");
String maxQuotaManager = config.configurationAt(MAX_QUOTA_MANAGER).getString(PROVIDER, FAKE); String maxQuotaManager = config.configurationAt(MAX_QUOTA_MANAGER).getString(PROVIDER, FAKE_IMPLEMENTATION);
String quotaManager = config.configurationAt(QUOTA_MANAGER).getString(PROVIDER, FAKE); String quotaManager = config.configurationAt(QUOTA_MANAGER_BEAN).getString(PROVIDER, FAKE_IMPLEMENTATION);
String quotaUpdater = config.configurationAt(UPDATES).getString(PROVIDER, FAKE); String quotaUpdater = config.configurationAt(UPDATES_BEAN).getString(PROVIDER, FAKE_IMPLEMENTATION);


BeanDefinitionRegistry registry = (BeanDefinitionRegistry) beanFactory; BeanDefinitionRegistry registry = (BeanDefinitionRegistry) beanFactory;


Expand All @@ -70,53 +72,53 @@ public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory)


private void registerAliasForQuotaUpdater(String quotaUpdater, BeanDefinitionRegistry registry) { private void registerAliasForQuotaUpdater(String quotaUpdater, BeanDefinitionRegistry registry) {
if (quotaUpdater.equalsIgnoreCase(EVENT)) { if (quotaUpdater.equalsIgnoreCase(EVENT)) {
registry.registerAlias("eventQuotaUpdater", QUOTA_UPDATER); registry.registerAlias("eventQuotaUpdater", QUOTA_UPDATER_BEAN);
} else if (quotaUpdater.equalsIgnoreCase(FAKE)) { } else if (quotaUpdater.equalsIgnoreCase(FAKE_IMPLEMENTATION)) {
registry.registerAlias("noQuotaUpdater", QUOTA_UPDATER); registry.registerAlias("noQuotaUpdater", QUOTA_UPDATER_BEAN);
} else { } else {
throw new FatalBeanException("Unreadable value for Quota Updater : " + quotaUpdater); throw new FatalBeanException("Unreadable value for Quota Updater : " + quotaUpdater);
} }
} }


private void registerAliasForQuotaManager(String quotaManager, BeanDefinitionRegistry registry) { private void registerAliasForQuotaManager(String quotaManager, BeanDefinitionRegistry registry) {
if (quotaManager.equalsIgnoreCase(FAKE)) { if (quotaManager.equalsIgnoreCase(FAKE_IMPLEMENTATION)) {
registry.registerAlias("noQuotaManager", QUOTA_MANAGER); registry.registerAlias("noQuotaManager", QUOTA_MANAGER_BEAN);
} else if (quotaManager.equalsIgnoreCase("store")) { } else if (quotaManager.equalsIgnoreCase("store")) {
registry.registerAlias("storeQuotaManager", QUOTA_MANAGER); registry.registerAlias("storeQuotaManager", QUOTA_MANAGER_BEAN);
} else { } else {
throw new FatalBeanException("Unreadable value for Quota Manager : " + quotaManager); throw new FatalBeanException("Unreadable value for Quota Manager : " + quotaManager);
} }
} }


private void registerAliasForMaxQuotaManager(String maxQuotaManager, BeanDefinitionRegistry registry) { private void registerAliasForMaxQuotaManager(String maxQuotaManager, BeanDefinitionRegistry registry) {
if (maxQuotaManager.equalsIgnoreCase(FAKE)) { if (maxQuotaManager.equalsIgnoreCase(FAKE_IMPLEMENTATION)) {
registry.registerAlias("noMaxQuotaManager", MAX_QUOTA_MANAGER); registry.registerAlias("noMaxQuotaManager", MAX_QUOTA_MANAGER);
} else if (maxQuotaManager.equalsIgnoreCase(IN_MEMORY)) { } else if (maxQuotaManager.equalsIgnoreCase(IN_MEMORY_IMPLEMENTATION)) {
registry.registerAlias("inMemoryMaxQuotaManager", MAX_QUOTA_MANAGER); registry.registerAlias("inMemoryMaxQuotaManager", MAX_QUOTA_MANAGER);
} else if (maxQuotaManager.equalsIgnoreCase(CASSANDRA)) { } else if (maxQuotaManager.equalsIgnoreCase(CASSANDRA_IMPLEMENTATION)) {
registry.registerAlias("cassandraMaxQuotaManager", MAX_QUOTA_MANAGER); registry.registerAlias("cassandraMaxQuotaManager", MAX_QUOTA_MANAGER);
} else if (maxQuotaManager.equalsIgnoreCase(JPA)) { } else if (maxQuotaManager.equalsIgnoreCase(JPA_IMPLEMENTATION)) {
registry.registerAlias("jpaMaxQuotaManager", MAX_QUOTA_MANAGER); registry.registerAlias("jpaMaxQuotaManager", MAX_QUOTA_MANAGER);
} else { } else {
throw new FatalBeanException("Unreadable value for Max Quota Manager : " + maxQuotaManager); throw new FatalBeanException("Unreadable value for Max Quota Manager : " + maxQuotaManager);
} }
} }


private void registerAliasForCurrentQuotaManager(String currentQuotaManager, BeanDefinitionRegistry registry) { private void registerAliasForCurrentQuotaManager(String currentQuotaManager, BeanDefinitionRegistry registry) {
if (currentQuotaManager.equalsIgnoreCase(IN_MEMORY)) { if (currentQuotaManager.equalsIgnoreCase(IN_MEMORY_IMPLEMENTATION)) {
registry.registerAlias("inMemoryCurrentQuotaManager", CURRENT_QUOTA_MANAGER); registry.registerAlias("inMemoryCurrentQuotaManager", CURRENT_QUOTA_MANAGER_BEAN);
} else if (currentQuotaManager.equalsIgnoreCase(CASSANDRA)) { } else if (currentQuotaManager.equalsIgnoreCase(CASSANDRA_IMPLEMENTATION)) {
registry.registerAlias("cassandraCurrentQuotaManager", CURRENT_QUOTA_MANAGER); registry.registerAlias("cassandraCurrentQuotaManager", CURRENT_QUOTA_MANAGER_BEAN);
} else if (currentQuotaManager.equalsIgnoreCase(JPA)) { } else if (currentQuotaManager.equalsIgnoreCase(JPA_IMPLEMENTATION)) {
registry.registerAlias("jpaCurrentQuotaManager", CURRENT_QUOTA_MANAGER); registry.registerAlias("jpaCurrentQuotaManager", CURRENT_QUOTA_MANAGER_BEAN);
} else if (! currentQuotaManager.equalsIgnoreCase("none")) { } else if (! currentQuotaManager.equalsIgnoreCase("none")) {
throw new FatalBeanException("Unreadable value for Current Quota Manager : " + currentQuotaManager); throw new FatalBeanException("Unreadable value for Current Quota Manager : " + currentQuotaManager);
} }
} }


private void registerAliasForQuotaRootResolver(String quotaRootResolver, BeanDefinitionRegistry registry) { private void registerAliasForQuotaRootResolver(String quotaRootResolver, BeanDefinitionRegistry registry) {
if (quotaRootResolver.equals(DEFAULT)) { if (quotaRootResolver.equals(DEFAULT_IMPLEMENTATION)) {
registry.registerAlias("defaultQuotaRootResolver", QUOTA_ROOT_RESOLVER); registry.registerAlias("defaultQuotaRootResolver", QUOTA_ROOT_RESOLVER_BEAN);
} else { } else {
throw new FatalBeanException("Unreadable value for QUOTA ROOT resolver : " + quotaRootResolver); throw new FatalBeanException("Unreadable value for QUOTA ROOT resolver : " + quotaRootResolver);
} }
Expand Down

0 comments on commit 54c6402

Please sign in to comment.