MAILBOX-312 Silent some Eclipse warnings

mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java

@@ -657,7 +657,7 @@ public void searchForMessageShouldNotReturnMessagesFromMyDelegatedMailboxesICanN
         MailboxId delegatedMailboxId = mailboxManager.createMailbox(delegatedMailboxPath, sessionFromDelegater).get();
         MessageManager delegatedMessageManager = mailboxManager.getMailbox(delegatedMailboxId, sessionFromDelegater);
 
-        MessageId messageId = delegatedMessageManager.appendMessage(
+        delegatedMessageManager.appendMessage(
             new ByteArrayInputStream("Subject: test\r\n\r\ntestmail".getBytes()),
             new Date(),
             sessionFromDelegater,
@@ -692,7 +692,7 @@ public void searchForMessageShouldOnlySearchInMailboxICanRead() throws MailboxEx
         MailboxId otherMailboxId = mailboxManager.createMailbox(otherMailboxPath, sessionFromDelegater).get();
         MessageManager otherMailboxManager = mailboxManager.getMailbox(otherMailboxId, sessionFromDelegater);
 
-        MessageId messageId = otherMailboxManager.appendMessage(
+        otherMailboxManager.appendMessage(
             new ByteArrayInputStream("Subject: test\r\n\r\ntestmail".getBytes()),
             new Date(),
             sessionFromDelegater,
@@ -719,7 +719,7 @@ public void searchForMessageShouldIgnoreMailboxThatICanNotRead() throws MailboxE
         MailboxId otherMailboxId = mailboxManager.createMailbox(otherMailboxPath, sessionFromDelegater).get();
         MessageManager otherMessageManager = mailboxManager.getMailbox(otherMailboxId, sessionFromDelegater);
 
-        MessageId messageId = otherMessageManager.appendMessage(
+        otherMessageManager.appendMessage(
             new ByteArrayInputStream("Subject: test\r\n\r\ntestmail".getBytes()),
             new Date(),
             sessionFromDelegater,
@@ -746,7 +746,7 @@ public void searchForMessageShouldCorrectlyExcludeMailbox() throws MailboxExcept
         MailboxId otherMailboxId = mailboxManager.createMailbox(otherMailboxPath, session).get();
         MessageManager otherMessageManager = mailboxManager.getMailbox(otherMailboxId, session);
 
-        MessageId messageId = otherMessageManager.appendMessage(
+        otherMessageManager.appendMessage(
             new ByteArrayInputStream("Subject: test\r\n\r\ntestmail".getBytes()),
             new Date(),
             session,
@@ -773,7 +773,7 @@ public void searchForMessageShouldPriorizeExclusionFromInclusion() throws Mailbo
         MailboxId otherMailboxId = mailboxManager.createMailbox(otherMailboxPath, session).get();
         MessageManager otherMessageManager = mailboxManager.getMailbox(otherMailboxId, session);
 
-        MessageId messageId = otherMessageManager.appendMessage(
+        otherMessageManager.appendMessage(
             new ByteArrayInputStream("Subject: test\r\n\r\ntestmail".getBytes()),
             new Date(),
             session,

mailbox/api/src/test/java/org/apache/james/mailbox/manager/ManagerTestResources.java

@@ -41,14 +41,14 @@
 /**
  * Provide an initialized Mailbox environment where we can run managers tests
  */
-public class ManagerTestResources {
+public class ManagerTestResources<T extends MailboxManager> {
 
     public static final String USER = "user@domain.org";
     public static final String USER_PASS = "pass";
     public static final String OTHER_USER = "otherUser@domain.org";
     public static final String OTHER_USER_PASS = "otherPass";
 
-    private MailboxManager mailboxManager;
+    private T mailboxManager;
 
     private MailboxPath inbox;
     private MessageManager messageManager;
@@ -61,9 +61,9 @@ public class ManagerTestResources {
     private GroupMembershipResolver groupMembershipResolver;
     private QuotaRootResolver quotaRootResolver;
 
-    private IntegrationResources integrationResources;
+    private IntegrationResources<T> integrationResources;
 
-    public ManagerTestResources(IntegrationResources integrationResources) throws Exception {
+    public ManagerTestResources(IntegrationResources<T> integrationResources) throws Exception {
         this.integrationResources = integrationResources;
         maxQuotaManager = integrationResources.createMaxQuotaManager();
         groupMembershipResolver = integrationResources.createGroupMembershipResolver();
@@ -121,7 +121,7 @@ public MailboxSession getSession() {
         return session;
     }
 
-    public IntegrationResources getIntegrationResources() {
+    public IntegrationResources<T> getIntegrationResources() {
         return integrationResources;
     }
 

mailbox/api/src/test/java/org/apache/james/mailbox/manager/QuotaMessageManagerTest.java

@@ -41,9 +41,9 @@
  * Tests are performed with sufficient rights to ensure all underlying functions behave well.
  * Quota are adjusted and we check that exceptions are well thrown.
  */
-public abstract class QuotaMessageManagerTest {
+public abstract class QuotaMessageManagerTest<T extends MailboxManager> {
 
-    private ManagerTestResources resources;
+    private ManagerTestResources<T> resources;
 
     private MessageManager messageManager;
     private MailboxManager mailboxManager;
@@ -54,7 +54,7 @@ public abstract class QuotaMessageManagerTest {
     private MailboxPath inbox;
     private MailboxPath subFolder;
 
-    protected abstract ManagerTestResources createResources() throws Exception;
+    protected abstract ManagerTestResources<T> createResources() throws Exception;
 
     @Before
     public void setUp() throws Exception {

mailbox/lucene/src/test/java/org/apache/james/mailbox/lucene/search/LuceneMailboxMessageSearchIndexTest.java

@@ -39,7 +39,6 @@
 import org.apache.james.mailbox.model.MailboxId;
 import org.apache.james.mailbox.model.MailboxPath;
 import org.apache.james.mailbox.model.MessageId;
-import org.apache.james.mailbox.model.MultimailboxesSearchQuery;
 import org.apache.james.mailbox.model.SearchQuery;
 import org.apache.james.mailbox.model.SearchQuery.AddressType;
 import org.apache.james.mailbox.model.SearchQuery.DateResolution;

mailbox/memory/src/test/java/org/apache/james/mailbox/inmemory/manager/InMemoryQuotaMailboxMessageManagerTest.java

@@ -20,18 +20,19 @@
 
 import org.apache.james.mailbox.manager.ManagerTestResources;
 import org.apache.james.mailbox.manager.QuotaMessageManagerTest;
+import org.apache.james.mailbox.store.StoreMailboxManager;
 
 /**
  * Test for quota support upon basic MailboxMessage manager operation.
  *
  * Tests are performed with sufficient rights to ensure all underlying functions behave well.
  * Quota are adjusted and we check that exceptions are well thrown.
  */
-public class InMemoryQuotaMailboxMessageManagerTest extends QuotaMessageManagerTest {
+public class InMemoryQuotaMailboxMessageManagerTest extends QuotaMessageManagerTest<StoreMailboxManager> {
 
     @Override
-    protected ManagerTestResources createResources() throws Exception {
-        return new ManagerTestResources(new InMemoryIntegrationResources());
+    protected ManagerTestResources<StoreMailboxManager> createResources() throws Exception {
+        return new ManagerTestResources<StoreMailboxManager>(new InMemoryIntegrationResources());
     }
 
 }

mailbox/store/src/main/java/org/apache/james/mailbox/store/search/SimpleMessageSearchIndex.java

@@ -22,7 +22,6 @@
 import java.util.EnumSet;
 import java.util.Iterator;
 import java.util.List;
-import java.util.Optional;
 import java.util.SortedSet;
 import java.util.TreeSet;
 import java.util.stream.Stream;

mailbox/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManagerTest.java

@@ -40,10 +40,8 @@
 import org.apache.james.mailbox.model.MessageId;
 import org.apache.james.mailbox.model.MessageId.Factory;
 import org.apache.james.mailbox.model.TestId;
-import org.apache.james.mailbox.model.search.MailboxNameExpression;
 import org.apache.james.mailbox.model.search.MailboxQuery;
 import org.apache.james.mailbox.model.search.PrefixedRegex;
-import org.apache.james.mailbox.model.search.PrefixedWildcard;
 import org.apache.james.mailbox.store.mail.MailboxMapper;
 import org.apache.james.mailbox.store.mail.model.Mailbox;
 import org.apache.james.mailbox.store.mail.model.impl.MessageParser;

mailbox/store/src/test/java/org/apache/james/mailbox/store/search/AbstractMessageSearchIndexTest.java

@@ -37,11 +37,8 @@
 import org.apache.james.mailbox.MessageManager;
 import org.apache.james.mailbox.exception.MailboxException;
 import org.apache.james.mailbox.model.ComposedMessageId;
-import org.apache.james.mailbox.model.MailboxACL;
-import org.apache.james.mailbox.model.MailboxId;
 import org.apache.james.mailbox.model.MailboxPath;
 import org.apache.james.mailbox.model.MessageId;
-import org.apache.james.mailbox.model.MultimailboxesSearchQuery;
 import org.apache.james.mailbox.model.SearchQuery;
 import org.apache.james.mailbox.model.SearchQuery.AddressType;
 import org.apache.james.mailbox.model.SearchQuery.DateResolution;

protocols/imap/src/main/java/org/apache/james/imap/processor/DeleteACLProcessor.java

@@ -38,7 +38,6 @@
 import org.apache.james.mailbox.exception.MailboxNotFoundException;
 import org.apache.james.mailbox.exception.UnsupportedRightException;
 import org.apache.james.mailbox.model.MailboxACL;
-import org.apache.james.mailbox.model.MailboxACL.EditMode;
 import org.apache.james.mailbox.model.MailboxACL.EntryKey;
 import org.apache.james.mailbox.model.MailboxPath;
 import org.apache.james.metrics.api.MetricFactory;

server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/delivery/MailboxAppenderTest.java

@@ -33,6 +33,7 @@
 import org.apache.james.mailbox.model.MessageRange;
 import org.apache.james.mailbox.model.MessageResult;
 import org.apache.james.mailbox.model.MessageResultIterator;
+import org.apache.james.mailbox.store.StoreMailboxManager;
 import org.apache.mailet.base.test.MimeMessageBuilder;
 import org.junit.After;
 import org.junit.Before;
@@ -65,7 +66,7 @@ public void setUp() throws Exception {
 
         integrationResources = new InMemoryIntegrationResources();
         integrationResources.init();
-        mailboxManager = new ManagerTestResources(integrationResources).getMailboxManager();
+        mailboxManager = new ManagerTestResources<StoreMailboxManager>(integrationResources).getMailboxManager();
         testee = new MailboxAppender(mailboxManager);
 
         session = mailboxManager.createSystemSession("TEST");

server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesDestructionProcessor.java

@@ -38,7 +38,6 @@
 import org.apache.james.mailbox.model.MessageId;
 import org.apache.james.mailbox.model.MessageResult;
 import org.apache.james.metrics.api.MetricFactory;
-import org.apache.james.metrics.api.TimeMetric;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

server/protocols/jmap/src/main/java/org/apache/james/jmap/model/mailbox/MailboxNamespace.java

@@ -33,6 +33,7 @@ public enum Type {
         Delegated("Delegated"),
         Personal("Personal");
 
+        @SuppressWarnings("unused")
         private final String type;
 
         Type(String type) {