JAMES-2251 Avoid creating mutableDomains in AbstractDomainList.getDom…

…ains()
apache · Dec 12, 2017 · 9c871fe · 9c871fe
1 parent f4b6276
commit 9c871fe
Showing 1 changed file with 18 additions and 17 deletions.
diff --git a/...r/data/data-library/src/main/java/org/apache/james/domainlist/lib/AbstractDomainList.java b/...r/data/data-library/src/main/java/org/apache/james/domainlist/lib/AbstractDomainList.java
@@ -21,7 +21,6 @@
 
 import java.net.InetAddress;
 import java.net.UnknownHostException;
-import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 import java.util.Locale;
@@ -40,6 +39,7 @@
 import com.google.common.base.Strings;
 import com.google.common.base.Throwables;
 import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Iterables;
 
 /**
  * All implementations of the DomainList interface should extends this abstract
@@ -151,32 +151,33 @@ public boolean containsDomain(String domain) throws DomainListException {
     }
 
     @Override
-    public List<String> getDomains() throws DomainListException {
+    public ImmutableList<String> getDomains() throws DomainListException {
         List<String> domains = getDomainListInternal();
-
+        ImmutableList<String> detectedDomains = detectDomains();
-        // create mutable copy, some subclasses return ImmutableList
+        // Guava does not support concatenating ImmutableLists at this time:
-        ArrayList<String> mutableDomains = new ArrayList<>(domains);
+        // https://stackoverflow.com/questions/37919648/concatenating-immutablelists
-        List<String> detectedDomains = detectDomains();
+        // A work-around is to use Iterables.concat() until something like
-        mutableDomains.addAll(detectedDomains);
+        // https://github.com/google/guava/issues/1029 is implemented.
-        mutableDomains.addAll(detectIps(mutableDomains));
+        ImmutableList<String> detectedIps = detectIps(Iterables.concat(domains, detectedDomains));
+        Iterable<String> allDomains = Iterables.concat(domains, detectedDomains, detectedIps);
 
         if (LOGGER.isDebugEnabled()) {
-            for (String domain : mutableDomains) {
+            for (String domain : allDomains) {
                 LOGGER.debug("Handling mail for: " + domain);
             }
         }
 
-        return ImmutableList.copyOf(mutableDomains);
+        return ImmutableList.copyOf(allDomains);
     }
 
-    private List<String> detectIps(ArrayList<String> mutableDomains) {
+    private ImmutableList<String> detectIps(Iterable<String> domains) {
         if (autoDetectIP) {
-            return getDomainsIP(mutableDomains, dns, LOGGER);
+            return getDomainsIP(domains, dns, LOGGER);
         }
         return ImmutableList.of();
     }
 
-    private List<String> detectDomains() {
+    private ImmutableList<String> detectDomains() {
         if (autoDetect) {
             String hostName;
             try {
@@ -197,11 +198,11 @@ private List<String> detectDomains() {
      * Return a List which holds all ipAddress of the domains in the given List
      * 
      * @param domains
-     *            List of domains
+     *            Iterable of domains
      * @return domainIP List of ipaddress for domains
      */
-    private static List<String> getDomainsIP(List<String> domains, DNSService dns, Logger log) {
+    private static ImmutableList<String> getDomainsIP(Iterable<String> domains, DNSService dns, Logger log) {
-        return domains.stream()
+        return Guavate.stream(domains)
             .flatMap(domain -> getDomainIP(domain, dns, log).stream())
             .distinct()
             .collect(Guavate.toImmutableList());
@@ -210,7 +211,7 @@ private static List<String> getDomainsIP(List<String> domains, DNSService dns, L
     /**
      * @see #getDomainsIP(List, DNSService, Logger)
      */
-    private static List<String> getDomainIP(String domain, DNSService dns, Logger log) {
+    private static ImmutableList<String> getDomainIP(String domain, DNSService dns, Logger log) {
         try {
             return dns.getAllByName(domain).stream()
                 .map(InetAddress::getHostAddress)