Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CSV Data Set Config use specified encoding #1869

Closed
asfimport opened this issue Feb 26, 2007 · 3 comments
Closed

Make CSV Data Set Config use specified encoding #1869

asfimport opened this issue Feb 26, 2007 · 3 comments

Comments

@asfimport
Copy link
Collaborator

Alf Hogemark (Bug 41704):
Currently, the CSV Data Set Config does not allow the user to specify what
character set encoding is used in the csv file which contains the test data to
use in a Jmeter test.

Therefore, the csv data files must have the default system character set
encoding. Currently, it is the java class FileReader which is used to read the
file, and that assumes the default platform character set encoding for the file.

It would be useful to be able to specify the character set encoding used in a
csv data file, so that you can use different encodings. That will also allow you
to use the same data files on different operating systems, which can have
different default character set encodings.

OS: All

@asfimport
Copy link
Collaborator Author

Alf Hogemark (migrated from Bugzilla):
This is a patch agaist SVN
svn.apache.org/repos/asf/jakarta/jmeter/branches/rel-2-2 as of today.

Comments / suggestions to the patch are welcomed.

Created attachment patch_csv_data_set_with_encoding.patch: Suggested patch to add encoding to CSV data set

@asfimport
Copy link
Collaborator Author

Sebb (migrated from Bugzilla):
Thanks for the contribution.

Looks mostly OK.

However, it changes the public API of the FileServer class, as the reserveFile
method now has an extra parameter. This could cause 3rd party applications to
fail. Easy enough to resolve by overloading the method.

Also, the encoding could perhaps be added to the FileEntry class instead of
using a separate HashMap.

I'll see about adding this - no need to recreate the patch at present.

@asfimport
Copy link
Collaborator Author

Sebb (migrated from Bugzilla):
Added to SVN. Will be in nightly builds after r516795.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant