Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to AssertionResult and display AssertionResult in ViewResultsFull #1886

Closed
asfimport opened this issue Mar 17, 2007 · 2 comments
Closed

Comments

@asfimport
Copy link
Collaborator

Alf Hogemark (Bug 41873):
Hi

I think it would be nice if the AssertionResult had a name, with the value for
Assertion that caused the AssertionResult.

I also think it would be useful if the ViewResultsFullVisualizer displayed
assertions that failed as child nodes of the sample where it was evaluated.

The AssertionVisualizer should also display the name of the AssertionResult.

OS: All

@asfimport
Copy link
Collaborator Author

Alf Hogemark (migrated from Bugzilla):
The suggested patch adds a name property to the AssertionResult, and for all
the different Assertions that creates AssertionResult, the name of the
AssertionResult is set to the same as the name of the Assertion.

The AssertionVizualizer is modified to display the name of the AssertionResult.

The ViewResultsFullVisualizer is modified to display failed assertions as child
nodes to the samples.
If you do not like the modifications to the ViewResultsFullVisualizer, you can
apply the other parts of the request.

Created attachment patch_for_41873.patch: Suggested patch

@asfimport
Copy link
Collaborator Author

Sebb (migrated from Bugzilla):
Thanks very much.

Added to SVN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant