KNOX-3025 - Optimize knoxauth.js #892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RedYetiDev - I've just approved your JIRA account request. Could you please login and create the relevant KNOX ticket (explaining the issues in the current implementation and your suggestions)? Then you can update this PR with the appropriate KNOX JIRA ID. |
RedYetiDev
changed the title
RedYetiDev
changed the title
|
Apologies for the mistake, Jira pulled up the wrong issue initially (weird!). Please see KNOX-3025 |
|
Please ignore the close, I will re open this shortly, I accidentally deleted the repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(It is very important that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)
What changes were proposed in this pull request?
This PR reimplements the
knoxauth.jsfile using modern browser features. Additionally, it changes the jQuery functions back to native JavaScript functions for speed and complexity reasons, and removes the userAgent declaration, as it is never used.How was this patch tested?
This patch was tested manually via each function one at a time.
get("param") -> 'value' with ?param=valuetestSameOrigin("https://some.other.site") -> false with https://some.safe.sitetestSameOrigin("https://same.safe.site") -> true with https://some.safe.siteredirect("https://www.google.com") -> Redirection successfulunicodeBase64Encode("Hello World") -> 'SGVsbG8gV29ybGQ='(Althoughunescapeandescapeare deprecated, I leftunescapein the code)keypressed({keyCode:13}) -> login() calledlogin() with admin/password and ?originalUrl=TEST_ORIG_URL -> Redirection to redirecting.html?originalUrl=TEST_ORIG_URL(Initially failure, see commit e417884)Please review Knox Contributing Process before opening a pull request.