Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issues: add the support of all missing commands in the list type #1512

Open
5 of 7 tasks
infdahai opened this issue Jun 22, 2023 · 8 comments
Open
5 of 7 tasks
Labels
enhancement type enhancement

Comments

@infdahai
Copy link
Contributor

infdahai commented Jun 22, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

This issue considers to support the blmove, blmpop, brpoplpush, lmpop, lpos commands.

Solution

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@infdahai infdahai added the enhancement type enhancement label Jun 22, 2023
@infdahai infdahai changed the title Add the support of the GEOSEARCH, GEOSEARCHSTORE comands Tracking issues: add the support of the GEOSEARCH, GEOSEARCHSTORE comands Jun 22, 2023
@infdahai infdahai changed the title Tracking issues: add the support of the GEOSEARCH, GEOSEARCHSTORE comands Tracking issues: add the support of all missing comands in the list type Jun 22, 2023
@IoCing
Copy link
Contributor

IoCing commented Jun 26, 2023

i can do this

@PragmaTwice
Copy link
Member

PragmaTwice commented Jun 27, 2023

It will be better if you can open an issue for every command you mention here.

@infdahai
Copy link
Contributor Author

It will be better if you can open an issue for every command you mention here.

OK, I will open some issues in the evening.

@infdahai
Copy link
Contributor Author

Hi @IoCing, you can select specific commands if you want.

@torwig
Copy link
Contributor

torwig commented Jun 27, 2023

@infdahai Please have a look, I see that the LLEN, LINSERT, LPOP, RPUSH are also supported. The formatting in the file is a little weird.
image

@infdahai
Copy link
Contributor Author

@infdahai Please have a look, I see that the LLEN, LINSERT, LPOP, RPUSH are also supported. The formatting in the file is a little weird. image

OK, I'm sorry for this. My window wasn't big enough, so I didn't notice the layout. I update this issue now.

@torwig
Copy link
Contributor

torwig commented Jun 27, 2023

@infdahai And you can edit this source file to list each command on a separate line, introducing a small PR.

@infdahai
Copy link
Contributor Author

@infdahai And you can edit this source file to list each command on a separate line, introducing a small PR.

I get it.

@tisonkun tisonkun pinned this issue Jun 28, 2023
@PragmaTwice PragmaTwice unpinned this issue Oct 15, 2023
@tisonkun tisonkun changed the title Tracking issues: add the support of all missing comands in the list type Tracking issues: add the support of all missing commands in the list type Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement
Projects
None yet
Development

No branches or pull requests

4 participants