Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Presto TABLE_NOT_FOUND returns lower case table name causing has_table regex to fail #6485

Open
3 of 4 tasks
tboddyspargo opened this issue Jun 19, 2024 · 1 comment
Labels
kind:bug This is a clearly a bug priority:major

Comments

@tboddyspargo
Copy link

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

Issue migrated from dropbox/PyHive#302

     regex = r"Table\ \'.*{}\'\ does\ not\ exist".format(re.escape(table_name))
            
     if msg and re.search(regex, msg):
            raise exc.NoSuchTableError(table_name)
        else:
            raise

with presto and Oracle, Oracle has table name with upper case, but table name in error message which return from presto is with lower case, so re.search method will return None, then has_table method will exit with uncaught exception.

maybe we should use re.IGNORECASE in re.search method

Affects Version(s)

master (pyhive v0.7.0)

Kyuubi Server Log Output

No response

Kyuubi Engine Log Output

No response

Kyuubi Server Configurations

No response

Kyuubi Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
  • No. I cannot submit a PR at this time.
@tboddyspargo tboddyspargo added kind:bug This is a clearly a bug priority:major labels Jun 19, 2024
Copy link

Hello @tboddyspargo,
Thanks for finding the time to report the issue!
We really appreciate the community's efforts to improve Apache Kyuubi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug This is a clearly a bug priority:major
Projects
None yet
Development

No branches or pull requests

1 participant