Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ZOOKEEPER-4377 to Kyuubi shaded ZooKeeper 3.4 and 3.6 #6496

Open
2 of 4 tasks
pan3793 opened this issue Jun 24, 2024 · 2 comments
Open
2 of 4 tasks

Port ZOOKEEPER-4377 to Kyuubi shaded ZooKeeper 3.4 and 3.6 #6496

pan3793 opened this issue Jun 24, 2024 · 2 comments

Comments

@pan3793
Copy link
Member

pan3793 commented Jun 24, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Port ZOOKEEPER-4377 (apache/zookeeper#1764) to https://github.com/apache/kyuubi-shaded/tree/master/kyuubi-relocated-zookeeper-parent/kyuubi-relocated-zookeeper-34 and https://github.com/apache/kyuubi-shaded/tree/master/kyuubi-relocated-zookeeper-parent/kyuubi-relocated-zookeeper-36

How should we improve?

By default, Kyuubi uses the shaded ZooKeeper 3.4 client to gain compatibility, while it may cause NPE when accessing a higher version of the ZooKeeper server, for example, #1894, we should backport ZOOKEEPER-4377 to gain a clear error message.

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@Madhukar98
Copy link

Hi @pan3793, I would like to take this up. But I might need some more clarity. Are we supposed to make these changes in zookeeper repo? Because I can't see the KeeperException file in kyuubi-relocated-zookeeper.

@pan3793
Copy link
Member Author

pan3793 commented Jul 4, 2024

@Madhukar98 you can refer to apache/kyuubi-shaded#28 and apache/kyuubi-shaded#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants