Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Provide kyuubiServerPrincipal as alias for principal in JDBC parameter #3887

Closed
2 of 5 tasks
pan3793 opened this issue Dec 2, 2022 · 2 comments
Closed
2 of 5 tasks

[Improvement] Provide kyuubiServerPrincipal as alias for principal in JDBC parameter #3887

pan3793 opened this issue Dec 2, 2022 · 2 comments
Assignees
@lightning-L
Labels
help wanted

Comments

@pan3793
Copy link
Member

pan3793 commented Dec 2, 2022

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Kyuubi JDBC Driver introduced new parameters kyuubiClientPrincipal and kyuubiClientKeytabin #3023, and it had a parameter principal which is inherited from Hive JDBC Driver, it's quite confusing, so we'd better to add an alias kyuubiServerPrincipal for principal to make it clear and consistent.

How should we improve?

Provide kyuubiServerPrincipal as alias for principal in JDBC parameter

Are you willing to submit PR?

  • Yes. I can submit a PR independently to improve.
  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@lightning-L
Copy link
Contributor

I am interested in this task. Please assign it to me.

@pan3793
Copy link
Member Author

pan3793 commented Dec 2, 2022

Thanks @lightning-L

lightning-L added a commit to lightning-L/kyuubi that referenced this issue Dec 8, 2022
@lightning-L
[KYUUBI apache#3887] Provide kyuubiServerPrincipal as alias for princ…
8d0f42d 
…ipal in JDBC parameter
lightning-L added a commit to lightning-L/kyuubi that referenced this issue Dec 8, 2022
@lightning-L
[KYUUBI apache#3887] Provide kyuubiServerPrincipal as alias for princ…
6556623 
…ipal in JDBC parameter
@pan3793 pan3793 mentioned this issue Dec 12, 2022
Closed
3 tasks
lightning-L added a commit to lightning-L/kyuubi that referenced this issue Apr 24, 2023
@lightning-L
[KYUUBI apache#3887][FOLLOWUP] fix kyuubiServerPrincipal logic in Kyu…
42a1232 
…ubiCommands
pan3793 pushed a commit that referenced this issue Apr 24, 2023
@lightning-L @pan3793
[KYUUBI #3887][FOLLOWUP] Fix kyuubiServerPrincipal logic in KyuubiCom…
b0d07f7 
…mands

### _Why are the changes needed?_

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4764 from lightning-L/kyuubi-3887-followup.

Closes #3887

42a1232 [Tianlin Liao] [KYUUBI #3887][FOLLOWUP] fix kyuubiServerPrincipal logic in KyuubiCommands

Authored-by: Tianlin Liao <tiliao@ebay.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793 pushed a commit that referenced this issue Apr 24, 2023
@lightning-L @pan3793
[KYUUBI #3887][FOLLOWUP] Fix kyuubiServerPrincipal logic in KyuubiCom…
3f153c6 
…mands

### _Why are the changes needed?_

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4764 from lightning-L/kyuubi-3887-followup.

Closes #3887

42a1232 [Tianlin Liao] [KYUUBI #3887][FOLLOWUP] fix kyuubiServerPrincipal logic in KyuubiCommands

Authored-by: Tianlin Liao <tiliao@ebay.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit b0d07f7)
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lightning-L lightning-L

Labels
help wanted
Projects
None yet
Milestone
No milestone
2 participants
@lightning-L @pan3793