Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] AllKyuubiConfiguration generates redundant blank lines in Windows environment #5090

Closed
3 of 4 tasks
wForget opened this issue Jul 24, 2023 · 0 comments
Closed
3 of 4 tasks

[Bug] AllKyuubiConfiguration generates redundant blank lines in Windows environment #5090

wForget opened this issue Jul 24, 2023 · 0 comments
Labels
kind:bug This is a clearly a bug priority:major

Comments

@wForget
Copy link
Member

wForget commented Jul 24, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

AllKyuubiConfiguration generates redundant blank lines in Windows environment.

image

MarkdownBuilder uses Platform.EOL for buffer.mkString and com.vladsch.flexmark.util.sequence.LineAppendableImpl adds blankLine with SequenceUtils.EOL causing formattedLines to include both EOLs.

image

Affects Version(s)

master

Kyuubi Server Log Output

No response

Kyuubi Engine Log Output

No response

Kyuubi Server Configurations

No response

Kyuubi Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
  • No. I cannot submit a PR at this time.
@wForget wForget added kind:bug This is a clearly a bug priority:major labels Jul 24, 2023
@wForget wForget mentioned this issue Jul 24, 2023
Closed
3 tasks
pan3793 pushed a commit that referenced this issue Jul 24, 2023
@wForget @mans2singh @pan3793
[KYUUBI #5090] Fix AllKyuubiConfiguration to generate redundant blank…
9b40c38 
… lines in Windows

### _Why are the changes needed?_

close #5090

### _How was this patch tested?_

After this PR it generates normal settings file in windows.

- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

Closes #5091 from wForget/KYUUBI-5090.

Closes #5090

9e974c7 [wforget] fix
dc1ebfc [wforget] fix
2cbec60 [wforget] [KYUUBI-5090] Fix AllKyuubiConfiguration to generate redundant blank lines in Windows
ecc3b4a [mans2singh] [KYUUBI #5086] [KYUUBI # 5085] Update config section of deploy on kubernetes

Lead-authored-by: wforget <643348094@qq.com>
Co-authored-by: mans2singh <mans2singh@yahoo.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 026b88e)
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug This is a clearly a bug priority:major
Projects
None yet
Milestone
No milestone
1 participant
@wForget