Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][TRIVIAL] Don't use Log4j2's extended throwable conversion pattern in default logging configurations #5365

Closed
2 of 3 tasks
pan3793 opened this issue Oct 8, 2023 · 1 comment
Closed
2 of 3 tasks

[TASK][TRIVIAL] Don't use Log4j2's extended throwable conversion pattern in default logging configurations #5365

pan3793 opened this issue Oct 8, 2023 · 1 comment
Assignees
@ITzhangqiang
Labels
hacktoberfest hacktoberfest-accepted

Comments

@pan3793
Copy link
Member

pan3793 commented Oct 8, 2023 •
edited

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient knowledge and experience of this task, and I volunteer to be the mentor of this task to guide contributors to complete the task.

Skill requirements

  • How to use and configure with log4j2

Background and Goals

The Apache Spark Community found a performance regression with log4j2. See apache/spark#36747. We can follow it to fix the performance issue on our side.

Implementation steps

apache/spark#36747 has an implementation that we can refer to.

Add %ex pattern to the layout in tests, main code, and templates.

<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>

Additional context

Original reporter is @yaooqinn
@ITzhangqiang
Copy link
Contributor

I understand this task and want to have a try, l suppose l can complete it in 3 days.

ITzhangqiang added a commit to ITzhangqiang/kyuubi that referenced this issue Oct 11, 2023
@ITzhangqiang
[KYUUBI apache#5365] Don't use Log4j2's extended throwable conversion…
fcb98c5 
… pattern in default logging configurations
ITzhangqiang added a commit to ITzhangqiang/kyuubi that referenced this issue Oct 11, 2023
@ITzhangqiang
[KYUUBI apache#5365] Don't use Log4j2's extended throwable conversion…
4eba1f7 
… pattern in default logging configurations
ITzhangqiang added a commit to ITzhangqiang/kyuubi that referenced this issue Oct 11, 2023
@ITzhangqiang
[KYUUBI apache#5365] Don't use Log4j2's extended throwable conversion…
042c7a8 
… pattern in default logging configurations
ITzhangqiang added a commit to ITzhangqiang/kyuubi that referenced this issue Oct 11, 2023
@ITzhangqiang
[KYUUBI apache#5365] Don't use Log4j2's extended throwable conversion…
dbb9d8b 
… pattern in default logging configurations
pan3793 pushed a commit that referenced this issue Oct 11, 2023
@ITzhangqiang @pan3793
[KYUUBI #5365] Don't use Log4j2's extended throwable conversion patte…
8bb78f0 
…rn in default logging configurations

### _Why are the changes needed?_

The Apache Spark Community found a performance regression with log4j2. See apache/spark#36747.

This PR to fix the performance issue on our side.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_
No.

Closes #5400 from ITzhangqiang/KYUUBI_5365.

Closes #5365

dbb9d8b [ITzhangqiang] [KYUUBI #5365] Don't use Log4j2's extended throwable conversion pattern in default logging configurations

Authored-by: ITzhangqiang <itzhangqiang@163.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit e51095e)
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ITzhangqiang ITzhangqiang

Labels
hacktoberfest hacktoberfest-accepted
Projects
No open projects
2023 Kyuubi Code Contribution Program
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pan3793 @ITzhangqiang